-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross-project IAM binding support #955
Conversation
This includes some permissions to the existing service account in project-apps. Admin permission to the app data storage bucket and a project level permission.
/gcbrun |
Makes the iam_members component Blueprints-compatiblible.
/gcbrun |
examples/tfengine/generated/team/additional_iam_members/terraform.tfvars
Outdated
Show resolved
Hide resolved
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd wait for @xingao267 too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too
Few final comments. Almost there! Thanks @pasha-gh |
/gcbrun |
@pasha-gh LGTM, thanks! When you merge, clean up the commit messages for intermediate commits, as by default, it will include all commit message for all your commits in this PR. |
/gcbrun |
* Add recipe for cross-project IAM permissions Add cross-project IAM permission support for the following resources: storage buckets projects organizations folders
* Add recipe for cross-project IAM permissions Add cross-project IAM permission support for the following resources: storage buckets projects organizations folders
Supports cross-project IAM binding support for the following resources:
storage_bucket
project
organization
folder
Closes #828