New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Set Terraform required_version to >= 1.5 #152

Draft

NimJay wants to merge 1 commit into main from nimjay-required-version

Contributor

NimJay commented Sep 1, 2024

Please see this GitHub issue about requiring a minimum Terraform version between 1.3-1.5 for the "Three-tier web app" JSS (Jump Start Solution).
We'll need to do the above for all JSSs — including this JSS.


          feat: Set Terraform required_version to >= 1.5

1beffe9

Contributor Author

NimJay commented Sep 1, 2024

The integration test failed:

Error waiting to create function: Error waiting for Creating function: Error code 13, message: Build failed with status: INTERNAL_ERROR and message: An unexpected error occurred. Refer to build logs: https://console.cloud.google.com/cloud-build/builds;region=us-central1/3668e205-a538-4e5a-964d-b96ae3ce8835?project=741819713141. For more details see the logs at

I don't believe it's related to the change in this pull-request. Re-running.

Aside: I believe we've been seeing this same error message in production deployments. Might be worth investigating https://console.cloud.google.com/cloud-build/builds;region=us-central1/3668e205-a538-4e5a-964d-b96ae3ce8835?project=741819713141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

asrivas Awaiting requested review from asrivas asrivas will be requested when the pull request is marked ready for review asrivas is a code owner

davidcavazos Awaiting requested review from davidcavazos davidcavazos will be requested when the pull request is marked ready for review davidcavazos is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet