Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): relax test/setup TPG version constraint #74

Merged
merged 3 commits into from
Oct 25, 2023
Merged

chore(deps): relax test/setup TPG version constraint #74

merged 3 commits into from
Oct 25, 2023

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 9, 2023 •
edited by apeabody
Loading

No description provided.

@renovate-bot renovate-bot requested review from imrannayer and a team as code owners October 9, 2023 18:38
@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Oct 9, 2023
@dpebot
Copy link
Collaborator

dpebot commented Oct 9, 2023

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/major-terraform-google-provider branch from a080b46 to 0a6d7a2 Compare October 16, 2023 20:26
@dpebot
Copy link
Collaborator

dpebot commented Oct 16, 2023

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/major-terraform-google-provider branch from 0a6d7a2 to 84fa6b8 Compare October 17, 2023 15:49
@dpebot
Copy link
Collaborator

dpebot commented Oct 17, 2023

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/major-terraform-google-provider branch from 84fa6b8 to c5a29ac Compare October 17, 2023 16:08
@dpebot
Copy link
Collaborator

dpebot commented Oct 17, 2023

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/major-terraform-google-provider branch from c5a29ac to 25fa58e Compare October 17, 2023 17:01
@dpebot
Copy link
Collaborator

dpebot commented Oct 17, 2023

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/major-terraform-google-provider branch from 25fa58e to c037c68 Compare October 23, 2023 15:14
@dpebot
Copy link
Collaborator

dpebot commented Oct 23, 2023

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/major-terraform-google-provider branch from c037c68 to 2e6f77d Compare October 24, 2023 19:20
@dpebot
Copy link
Collaborator

dpebot commented Oct 24, 2023

/gcbrun

@parupappa
Copy link

@imrannayer

Hi ! We await your review.
We would be happy if you could review this module as soon as possible, because we would like to use it.

aleon1220
aleon1220 reviewed Oct 25, 2023
View reviewed changes
test/setup/versions.tf Outdated Show resolved Hide resolved
aleon1220
aleon1220 reviewed Oct 25, 2023
View reviewed changes
Copy link

@aleon1220 aleon1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a random reviewer. Looks great to me.

@dpebot
Copy link
Collaborator

dpebot commented Oct 25, 2023

/gcbrun

@apeabody apeabody self-assigned this Oct 25, 2023
@forking-renovate
Copy link

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@apeabody apeabody changed the title feat(deps): Update Terraform Google Provider to v5 (major) chore(deps): relax test/setup TPG version constraint Oct 25, 2023
@apeabody
Copy link
Contributor

Updated PR title to chore as this doesn't impact that actual module.

@dpebot
Copy link
Collaborator

dpebot commented Oct 25, 2023

/gcbrun

@apeabody apeabody merged commit f62299c into GoogleCloudPlatform:main Oct 25, 2023
4 checks passed
@imrannayer
Copy link
Member

@parupappa we already have relaxed version to 5 in PR #77. It is already merged and will be part of release 2.0. You can point to github directly if you want to use Terraform provider 5.x.

@parupappa
Copy link

@imrannayer @aleon1220 @apeabody

Thank you for your review and comments.
I appreciate everyone's support!☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleon1220 aleon1220 aleon1220 left review comments

@apeabody apeabody apeabody approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

Assignees

@apeabody apeabody

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@renovate-bot @dpebot @parupappa @apeabody @imrannayer @aleon1220