Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add auto_deploy_config block #84

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: add auto_deploy_config block #84

merged 2 commits into from
Dec 7, 2023

Conversation

imrannayer
Copy link
Member

fix #83

@imrannayer imrannayer requested a review from a team as a code owner December 7, 2023 15:17
apeabody
apeabody approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Suggested adding periods for consistency.

README.md Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@imrannayer imrannayer merged commit 468c904 into GoogleCloudPlatform:main Dec 7, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Dec 7, 2023
Merged
@imrannayer imrannayer self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto deploy settings are not being applied.
2 participants
@imrannayer @apeabody