Add client, permissions, monitoring and mfa configs to google_identity_platform_config #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y_platform_config (#9609) * Reapply "Add client config and permissions to google_identity_platform_config (#9417)" This reverts commit 1c1f4d2844b9708f272601555212700382a78e44. * Fix diff from API for GCIP client * Add mfa config to GCIP * Add multiTenant to google_identity_platform_config * Add monitoring and request Logging to google_identity_platform_config * Add test cases * Extend update test to the new attributes * Findings from review * First set of review findings from zli82016 * Fix monitoring permadiff via custom flatten * Fix client.permissions permadiff via custom flatten * Fix mfa.state permadiff * Adapt tests to latest changes * Ignore only outputs for the import verify [upstream:6029bee2dcd6180a177d33d3b96d4ae3967cc957] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
shuyama1
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-6029bee2dcd6180a177d33d3b96d4ae3967cc957
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add client, permissions, monitoring and mfa configs to
google_identity_platform_configFor client this also fixes the diff that was introduced in #9417 and reverted in #9447
Fixes hashicorp/terraform-provider-google/issues/14192, hashicorp/terraform-provider-google/issues/15712, hashicorp/terraform-provider-google/issues/13326, hashicorp/terraform-provider-google/issues/17063
Relates to: hashicorp/terraform-provider-google/issues/14194
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9609