fix github_app_installation_id format

GoogleCloudPlatform · Jul 11, 2024 · 393756f · 393756f
1 parent b68671a
commit 393756f
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 8 deletions.
diff --git a/5-app-infra/source_repos/service-catalog/modules/composer/README.md b/5-app-infra/source_repos/service-catalog/modules/composer/README.md
@@ -21,7 +21,7 @@ The following table outlines which of the suggested controls for Vertex Generati
 |------|-------------|------|---------|:--------:|
 | airflow\_config\_overrides | Airflow configuration properties to override. Property keys contain the section and property names, separated by a hyphen, for example "core-dags\_are\_paused\_at\_creation". | `map(string)` | `{}` | no |
 | env\_variables | Additional environment variables to provide to the Apache Airflow scheduler, worker, and webserver processes. Environment variable names must match the regular expression [a-zA-Z\_][a-zA-Z0-9\_]*. They cannot specify Apache Airflow software configuration overrides (they cannot match the regular expression AIRFLOW\_\_[A-Z0-9\_]+\_\_[A-Z0-9\_]+), and they cannot match any of the following reserved names: [AIRFLOW\_HOME,C\_FORCE\_ROOT,CONTAINER\_NAME,DAGS\_FOLDER,GCP\_PROJECT,GCS\_BUCKET,GKE\_CLUSTER\_NAME,SQL\_DATABASE,SQL\_INSTANCE,SQL\_PASSWORD,SQL\_PROJECT,SQL\_REGION,SQL\_USER]. | `map(any)` | `{}` | no |
-| github\_app\_installation\_id | The app installation ID that was created when installing Google Cloud Build in GitHub: https://github.com/apps/google-cloud-build. | `number` | n/a | yes |
+| github\_app\_installation\_id | The app installation ID that was created when installing Google Cloud Build in GitHub: https://github.com/apps/google-cloud-build. | `string` | `""` | no |
 | github\_name\_prefix | A name for your GitHub connection to Cloud Build. | `string` | `"github-modules"` | no |
 | github\_remote\_uri | URL of your GitHub repo. | `string` | n/a | yes |
 | github\_secret\_name | Name of the GitHub secret to extract GitHub token info. | `string` | `"github-api-token"` | no |

diff --git a/5-app-infra/source_repos/service-catalog/modules/composer/variables.tf b/5-app-infra/source_repos/service-catalog/modules/composer/variables.tf
@@ -108,8 +108,9 @@ variable "github_name_prefix" {
 }
 
 variable "github_app_installation_id" {
-  type        = number
+  type        = string
   description = "The app installation ID that was created when installing Google Cloud Build in GitHub: https://github.com/apps/google-cloud-build."
+  default = ""
 }
 
 variable "service_account_prefix" {

diff --git a/examples/machine-learning-pipeline/ml_business_unit/development/README.md b/examples/machine-learning-pipeline/ml_business_unit/development/README.md
@@ -3,7 +3,7 @@
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| github\_app\_installation\_id | The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build | `number` | `""` | no |
+| github\_app\_installation\_id | The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build | `string` | `""` | no |
 | github\_remote\_uri | The remote uri of your github repository | `string` | `""` | no |
 | instance\_region | The region where notebook instance will be created. A subnetwork must exists in the instance region. | `string` | n/a | yes |
 | remote\_state\_bucket | Backend bucket to load remote state information from previous steps. | `string` | n/a | yes |

diff --git a/examples/machine-learning-pipeline/ml_business_unit/development/variables.tf b/examples/machine-learning-pipeline/ml_business_unit/development/variables.tf
@@ -26,7 +26,7 @@ variable "remote_state_bucket" {
 
 variable "github_app_installation_id" {
   description = "The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build"
-  type        = number
+  type        = string
   default     = ""
 }
 variable "github_remote_uri" {

diff --git a/examples/machine-learning-pipeline/ml_business_unit/non-production/README.md b/examples/machine-learning-pipeline/ml_business_unit/non-production/README.md
@@ -3,7 +3,7 @@
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| github\_app\_installation\_id | The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build | `number` | `""` | no |
+| github\_app\_installation\_id | The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build | `string` | `""` | no |
 | github\_remote\_uri | The remote uri of your github repository | `string` | `""` | no |
 | instance\_region | The region where notebook instance will be created. A subnetwork must exists in the instance region. | `string` | n/a | yes |
 | remote\_state\_bucket | Backend bucket to load remote state information from previous steps. | `string` | n/a | yes |

diff --git a/examples/machine-learning-pipeline/ml_business_unit/non-production/variables.tf b/examples/machine-learning-pipeline/ml_business_unit/non-production/variables.tf
@@ -26,7 +26,7 @@ variable "remote_state_bucket" {
 
 variable "github_app_installation_id" {
   description = "The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build"
-  type        = number
+  type        = string
   default     = ""
 
 }

diff --git a/examples/machine-learning-pipeline/ml_business_unit/production/README.md b/examples/machine-learning-pipeline/ml_business_unit/production/README.md
@@ -3,7 +3,7 @@
 
 | Name | Description | Type | Default | Required |
 |------|-------------|------|---------|:--------:|
-| github\_app\_installation\_id | The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build | `number` | `""` | no |
+| github\_app\_installation\_id | The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build | `string` | `""` | no |
 | github\_remote\_uri | The remote uri of your github repository | `string` | `""` | no |
 | instance\_region | The region where notebook instance will be created. A subnetwork must exists in the instance region. | `string` | n/a | yes |
 | remote\_state\_bucket | Backend bucket to load remote state information from previous steps. | `string` | n/a | yes |

diff --git a/examples/machine-learning-pipeline/ml_business_unit/production/variables.tf b/examples/machine-learning-pipeline/ml_business_unit/production/variables.tf
@@ -26,7 +26,7 @@ variable "remote_state_bucket" {
 
 variable "github_app_installation_id" {
   description = "The app installation ID that was created when installing Google Cloud Build in Github: https://github.com/apps/google-cloud-build"
-  type        = number
+  type        = string
   default     = ""
 
 }