feat(module): Add ML Infra Projects Module and 4-projects refactor #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rprise-genai into refactor/ml-infra-projects
Co-authored-by: Daniel Andrade <[email protected]>
Co-authored-by: Daniel Andrade <[email protected]>
Co-authored-by: Daniel Andrade <[email protected]>
…/terraform-google-enterprise-genai into refactor/ml-infra-projects
Co-authored-by: Daniel Andrade <[email protected]>
Co-authored-by: Daniel Andrade <[email protected]>
Co-authored-by: Daniel Andrade <[email protected]>
Co-authored-by: Daniel Andrade <[email protected]>
…/terraform-google-enterprise-genai into refactor/ml-infra-projects
4-projects/modules/ml_infra_projects/service_catalog_project.tf
Outdated
Show resolved
Hide resolved
4-projects/modules/ml_infra_projects/service_catalog_project.tf
Outdated
Show resolved
Hide resolved
…rprise-genai into refactor/ml-infra-projects
caetano-colin
commented
May 22, 2024
| * limitations under the License. | ||
| */ | ||
|
|
||
| module "ml_infra_project" { |
There was a problem hiding this comment.
change this to ml_infra_projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first part of 4-projects refactoring
It will separate some code into terraform modules that will be used in deploying this code "on top of the foundation".
The modules are responsible for creating "artifact" and "service catalog" projects under "common" folder and executed in
business_unit_3/shared.Brief explanation about modules added on this PR:
ml_infra_projects: will create both artifacts and service catalog project under common folder, usingml_single_projectmoduleml_kms_key: Will create the project kms key and externalizesprevent_destroyvariable for the user.ml_single_project: This is a standalone version forsingle_projectfor this specific repo, assingle_projectis a code drawn from foundation and can heavily change in the future.