Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing APIs #41

Conversation

renato-rudnicki
Copy link
Contributor

@renato-rudnicki renato-rudnicki commented May 17, 2024

This PR adds missing API's which are necessary for 5-vpc-sc step.

@caetano-colin
Copy link
Contributor

Some observations:

I noticed there is redudant information on 5-app-infra/5-vpc-sc/README.md and 5-app-infra/README.md. I think it's better if we choose one of them to be the source of truth and remove the other one.

Objective is to make the step-by-step less confusing. If you want, you can include this on the scope of this PR.

LGTM

@sleighton2022 sleighton2022 merged commit 77ddfcd into GoogleCloudPlatform:main May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants