-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): Add RAGAS evaluation to RAG chain #50
feat(examples): Add RAGAS evaluation to RAG chain #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small comment, but LGTM.
@@ -59,6 +59,108 @@ When running the Notebook, you will reach a step that downloads an example PDF f | |||
- projects/200612033880 # Google Cloud Example Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could change the 200612033880
for project_number
or what that number means, or even projects/00000000000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case this project 200612033880
is a Google Cloud Projects that hosts a Storage Bucket that contains the PDF we are downloading
Update: Release 5.34.0 is out and was fixed on versions.tf: https://github.com/hashicorp/terraform-provider-google/releases/tag/v5.34.0 |
I was able to test the new provider version, the terraform version (5.34.0) fixes the issue we were having, this PR is ready to review/merge |
This PR add RAGAS evaluation to the GenAI Multimodal example.
It also adds steps on the README that instruct the user how to deploy using the infra pipeline (cloud build).