Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add deletion_policy in volumes #9

Merged
merged 10 commits into from
Feb 22, 2024
Merged

feat!: add deletion_policy in volumes #9

merged 10 commits into from
Feb 22, 2024

Conversation

imrannayer
Copy link
Member

@imrannayer imrannayer commented Feb 21, 2024 •
edited
Loading

fix #8
fix #10

@imrannayer imrannayer requested a review from a team as a code owner February 21, 2024 22:55
@imrannayer imrannayer changed the title fix: handle null snapshot_policy feat: add deletion_policy in volumes Feb 21, 2024
@imrannayer
Copy link
Member Author

/gcbrun

1 similar comment
@imrannayer
Copy link
Member Author

/gcbrun

@imrannayer
Copy link
Member Author

/gcbrun

1 similar comment
@imrannayer
Copy link
Member Author

/gcbrun

g-awmalik
g-awmalik reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@g-awmalik g-awmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits and questions.

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
versions.tf Show resolved Hide resolved
@imrannayer imrannayer changed the title feat: add deletion_policy in volumes feat!: add deletion_policy in volumes Feb 22, 2024
imrannayer and others added 2 commits February 22, 2024 10:12
@imrannayer
Copy link
Member Author

@g-awmalik plz review

@imrannayer imrannayer requested a review from g-awmalik February 22, 2024 17:03
@imrannayer imrannayer merged commit c786042 into GoogleCloudPlatform:main Feb 22, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Feb 22, 2024
Merged
@imrannayer imrannayer self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

Assignees

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add deletion_policy for volumes snapshot_policy - Attempt to get attribute from null value
2 participants
@imrannayer @g-awmalik