fix: remove pkg_tar workaround from temurin archive #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesayyn
force-pushed
the
fix_temurin_archive
branch
from
5d4c6c3
to
047dc86
Compare
|
🌳 🔄 Image Check This pull request has modified the following images: //java:java21_root_arm64_debian12
//java:java21_root_ppc64le_debian12
//java:java21_nonroot_amd64_debian12
//java:java21_nonroot_arm64_debian12
//java:java21_root_amd64_debian12
//java:java21_debug_nonroot_ppc64le_debian12
//java:java21_debug_root_arm64_debian12
//java:java21_debug_nonroot_amd64_debian12
//java:java21_debug_root_ppc64le_debian12
//java:java21_debug_root_amd64_debian12
//java:java21_debug_nonroot_arm64_debian12
//java:java21_nonroot_ppc64le_debian12You can check the details in the report here |
|
@thesayyn Current 0755 which looks incorrect to me. Is that just what's provided by the temurin archive? But I can't seem to figure out what's going on here. |
|
found some other issues here. Duplicate entries of the same file (ex: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the workaround for executable files in temurin_archive and replaces it with
tarfrom bazel-lib. This PR introduces a new system dependencyawkfor the build. @loosebazooka is awk installed on cloudbuild runners?Some diff is expected, because
tarrule preserves both numeric and non-numeric owner for files and defaults to file mode on disk.Also aspect-build/bazel-lib#829 landed, i will remove genrule once there's a new release of bazel-lib.