fix: enable Butteraugli and SSIMulacra support on Windows#65
Open
Adithyakp86 wants to merge 1 commit intoGooichand:masterfrom
Open
fix: enable Butteraugli and SSIMulacra support on Windows#65Adithyakp86 wants to merge 1 commit intoGooichand:masterfrom
Adithyakp86 wants to merge 1 commit intoGooichand:masterfrom
Conversation
- Update butter_exe() and ssimul_exe() to check for bundled Windows binaries in butteraugli/windows/ and ssimulacra/windows/ - Add shutil.which() fallback to find tools on system PATH - Create placeholder windows/ directories with .gitkeep - Add 15 unit tests for all exe helper functions
Author
|
once check this PR and merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#54
Summary
Closes #2 — External Tools (Butteraugli, SSIMulacra) Not Supported on Windows.
butter_exe() and ssimul_exe() in gui/utility.py previously returned
Noneon Windows, completely disabling these image quality metrics. This PR adds full Windows support.Changes
gui/utility.py
butteraugli/windows/butteraugli.exessimulacra/windows/ssimulacra.exeshutil.which()fallback for both functions — if no bundled binary is found, the systemPATHis searchedimport shutilat the top of the fileNew Directories
butteraugli.exessimulacra.exetests/unit/test_utility.py
NoneNoneHow It Works
Resolution follows a two-step process (matching the existing exiftool_exe() pattern):
.exein thewindows/subdirectoryshutil.which()to locate user-installed toolsTesting
All 33 tests passed (18 existing + 15 new):