Skip to content

Update to TaskChampion 1.0.2#31

Merged
djmitche merged 3 commits intoGothenburgBitFactory:masterfrom
djmitche:issue23
Jan 3, 2025
Merged

Update to TaskChampion 1.0.2#31
djmitche merged 3 commits intoGothenburgBitFactory:masterfrom
djmitche:issue23

Conversation

@djmitche
Copy link
Copy Markdown
Collaborator

@djmitche djmitche commented Jan 3, 2025

There are no breaking changes in this release. This is part of #23, the rest of which will wait until TaskChampion 2.0.0 is released.

There are no breaking changes in this release.
@djmitche djmitche requested a review from illya-laifu January 3, 2025 04:34
@illya-laifu
Copy link
Copy Markdown
Collaborator

This check fails, but I will bump the rust version in Cargo.toml, which should resolve the issue.

@illya-laifu
Copy link
Copy Markdown
Collaborator

This check fails, but I will bump the rust version in Cargo.toml, which should resolve the issue.

Disregard this, just noticed

 # This should match the MSRV of the `taskchampion` crate.
  rust-version = "1.78.0"

in the Cargo.toml.


The suggestion given by cargo is

 Either upgrade rustc or select compatible dependency versions with
`cargo update <name>@<current-ver> --precise <compatible-ver>`
where `<compatible-ver>` is the latest version supporting rustc 1.78.0

I was able to replicate this locally, will see if cargo can fix this.

@illya-laifu
Copy link
Copy Markdown
Collaborator

After sitting on this for awhile - downgrading dependencies because of a build issue sounds like a very ridiculous idea and shouldn't even have been a consideration.


This however stumped me - taskchampion@1.0.2 bullds with rustup@1.78.0, but this project doesn't, so something has changed, but I wasn't sure what.

However it finally hit me - something bumped version numbers in the lock file, causing incompatible dependencies to be installed.

@djmitche
Copy link
Copy Markdown
Collaborator Author

djmitche commented Jan 3, 2025

Summarizing, the update to Taskchampion pulled the latest aws-sdk-s3@1.67.0 (among others) and set that up in Cargo.lock, whereas taskchampion is currenly locked to aws-sdk-s3@1.65.0, which still builds on 1.78.0.

I thought cargo took the rust-version into account, but I guess not :(

Some judicious use of cargo update .. --precise should fix this, with cargo +1.78.0 build used to test if the versions are compatible.

I'm not sure what the best general solution to this will be.

@illya-laifu
Copy link
Copy Markdown
Collaborator

Could this be caused by the aws dependencies that are set to version 1 in taskchampion? It's obviously an overkill, but I wonder if those were to be set more precise, we wouldn't have this issue.

@djmitche
Copy link
Copy Markdown
Collaborator Author

djmitche commented Jan 3, 2025

Could this be caused by the aws dependencies that are set to version 1 in taskchampion? It's obviously an overkill, but I wonder if those were to be set more precise, we wouldn't have this issue.

Yeah, but I would like to get updates to those dependencies -- just within the bounds of the Rust MSRV. Maybe I'll just bump the MSRV for 2.0.0.

@djmitche djmitche merged commit fa4ff1b into GothenburgBitFactory:master Jan 3, 2025
@djmitche
Copy link
Copy Markdown
Collaborator Author

djmitche commented Jan 3, 2025

(did that in GothenburgBitFactory/taskchampion#523)

@djmitche
Copy link
Copy Markdown
Collaborator Author

djmitche commented Jan 9, 2025

It looks like 1.84.0 is the first version to do this msrv-aware resolution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants