Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

Feature/vm particlefx data #43

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Feature/vm particlefx data #43

merged 2 commits into from
Oct 26, 2023

Conversation

JaXt0r
Copy link
Collaborator

@JaXt0r JaXt0r commented Oct 26, 2023

Added C_PARTICLEFX elements from Particlefx.dat Daedalus VM.

Question for code quality: Do we need to cast int_32 into PxBool or is it fine being done automatically?

Current example:

PxBool pxVmInstancePfxGetPpsIsLooping(PxVmInstance const* instance) {
	return (PxBool) RCC(phoenix::c_particle_fx, instance)->pps_is_looping;
}

@lmichaelis
Copy link
Member

The explicit cast should be added but is not required. Ideally we'd use static_cast too but that's not too important :) Looks good 👍

@lmichaelis lmichaelis merged commit c2d8b01 into main Oct 26, 2023
5 checks passed
@lmichaelis lmichaelis added the enhancement New feature or request label Oct 26, 2023
@lmichaelis lmichaelis deleted the feature/vm_particlefx_data branch October 26, 2023 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants