Merge pull request #155 from Gottox/improve/modularize-utils

Improve/modularize utils
Gottox · Oct 5, 2023 · 4b8f748 · 4b8f748
2 parents b752dd3 + 19b9bb5
commit 4b8f748
Show file tree

Hide file tree

Showing 18 changed files with 19 additions and 14 deletions.
diff --git a/common/include/meson.build b/common/include/meson.build
@@ -1,5 +1,7 @@
 libsqsh_common_headers = files(
     'sqsh_data_private.h',
+    'sqsh_reader_private.h',
+    'sqsh_thread_private.h',
 )
 
 libsqsh_common_include = include_directories('.')
diff --git a/common/include/sqsh_common_private.h b/common/include/sqsh_common_private.h
@@ -36,6 +36,7 @@
 
 #include <sqsh_common.h>
 
+#include <stdint.h>
 #include <stdlib.h>
 #include <string.h>
 
@@ -99,7 +100,7 @@ sqsh_address_ref_create(uint32_t outer_offset, uint16_t inner_offset) {
 
 SQSH_NO_UNUSED static inline uint32_t
 sqsh_datablock_size(uint32_t size_info) {
-	return size_info & ~(1 << 24);
+	return size_info & (uint32_t) ~(1 << 24);
 }
 
 SQSH_NO_UNUSED static inline bool

diff --git a/libsqsh/include/sqsh_reader_private.h → common/include/sqsh_reader_private.h b/libsqsh/include/sqsh_reader_private.h → common/include/sqsh_reader_private.h
diff --git a/libsqsh/include/sqsh_thread_private.h → common/include/sqsh_thread_private.h b/libsqsh/include/sqsh_thread_private.h → common/include/sqsh_thread_private.h
diff --git a/common/meson.build b/common/meson.build
@@ -16,3 +16,8 @@ libsqsh_common = static_library(
     dependencies: libsqsh_common_dependencies,
     install: false,
 )
+
+libsqsh_common_dep = declare_dependency(
+    link_with: libsqsh_common,
+    include_directories: libsqsh_common_include,
+)
diff --git a/common/src/compression_options_data.c → common/src/data/compression_options_data.c b/common/src/compression_options_data.c → common/src/data/compression_options_data.c
diff --git a/common/src/directory_data.c → common/src/data/directory_data.c b/common/src/directory_data.c → common/src/data/directory_data.c
diff --git a/common/src/fragment_data.c → common/src/data/fragment_data.c b/common/src/fragment_data.c → common/src/data/fragment_data.c
diff --git a/common/src/inode_data.c → common/src/data/inode_data.c b/common/src/inode_data.c → common/src/data/inode_data.c
diff --git a/common/src/metablock_data.c → common/src/data/metablock_data.c b/common/src/metablock_data.c → common/src/data/metablock_data.c
diff --git a/common/src/superblock_data.c → common/src/data/superblock_data.c b/common/src/superblock_data.c → common/src/data/superblock_data.c
diff --git a/common/src/xattr_data.c → common/src/data/xattr_data.c b/common/src/xattr_data.c → common/src/data/xattr_data.c
diff --git a/common/src/meson.build b/common/src/meson.build
@@ -1,9 +1,11 @@
 libsqsh_common_sources = files(
-    'compression_options_data.c',
-    'directory_data.c',
-    'fragment_data.c',
-    'inode_data.c',
-    'metablock_data.c',
-    'superblock_data.c',
-    'xattr_data.c',
+    'data/compression_options_data.c',
+    'data/directory_data.c',
+    'data/fragment_data.c',
+    'data/inode_data.c',
+    'data/metablock_data.c',
+    'data/superblock_data.c',
+    'data/xattr_data.c',
+    'reader/reader.c',
+    'utils/thread.c',
 )
diff --git a/libsqsh/src/reader/reader.c → common/src/reader/reader.c b/libsqsh/src/reader/reader.c → common/src/reader/reader.c
diff --git a/libsqsh/src/utils/thread.c → common/src/utils/thread.c b/libsqsh/src/utils/thread.c → common/src/utils/thread.c
diff --git a/libsqsh/include/meson.build b/libsqsh/include/meson.build
@@ -4,9 +4,7 @@ libsqsh_private_headers = files(
     'sqsh_extract_private.h',
     'sqsh_mapper_private.h',
     'sqsh_metablock_private.h',
-    'sqsh_reader_private.h',
     'sqsh_table_private.h',
-    'sqsh_thread_private.h',
     'sqsh_tree_private.h',
     'sqsh_xattr_private.h',
 )

diff --git a/libsqsh/meson.build b/libsqsh/meson.build
@@ -8,6 +8,7 @@ endif
 
 libsqsh_dependencies = [
     cextras_dep,
+    libsqsh_common_dep,
 ]
 
 libsqsh_c_args = []
@@ -45,11 +46,9 @@ libsqsh = both_libraries(
     libsqsh_sources,
     include_directories: [
         libsqsh_private_include,
-        libsqsh_common_include,
         libsqsh_include,
     ],
     install: not meson.is_subproject(),
-    link_with: [libsqsh_common],
     c_args: libsqsh_c_args,
     dependencies: libsqsh_dependencies,
     version: meson.project_version(),

diff --git a/libsqsh/src/meson.build b/libsqsh/src/meson.build
@@ -30,7 +30,6 @@ libsqsh_sources = files(
     'mapper/static_mapper.c',
     'metablock/metablock_iterator.c',
     'metablock/metablock_reader.c',
-    'reader/reader.c',
     'table/export_table.c',
     'table/fragment_table.c',
     'table/id_table.c',
@@ -40,6 +39,5 @@ libsqsh_sources = files(
     'tree/walker.c',
     'utils/error.c',
     'utils/posix.c',
-    'utils/thread.c',
     'xattr/xattr_iterator.c',
 )