chores: reduce usage of SQSH_ERROR_TODO.

Gottox · May 20, 2023 · 8e1a788 · 8e1a788
1 parent f3a3a5c
commit 8e1a788
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/include/sqsh_error.h b/include/sqsh_error.h
@@ -75,6 +75,8 @@ enum SqshError {
 	SQSH_ERROR_MAPPER_INIT,
 	SQSH_ERROR_MAPPER_MAP,
 	SQSH_ERROR_CURL_INVALID_RANGE_HEADER,
+	SQSL_ERROR_ELEMENT_NOT_FOUND,
+	SQSH_ERROR_INVALID_ARGUMENT,
 	SQSH_ERROR_TODO,
 };
 

diff --git a/lib/archive/trailing_context.c b/lib/archive/trailing_context.c
@@ -47,12 +47,12 @@ sqsh__trailing_init(
 	uint64_t trailing_size;
 
 	if (archive_size <= trailing_start) {
-		rv = -SQSH_ERROR_TODO;
+		rv = -SQSH_ERROR_SIZE_MISSMATCH;
 		goto out;
 	}
 
 	if (SQSH_SUB_OVERFLOW(archive_size, trailing_start, &trailing_size)) {
-		rv = -SQSH_ERROR_TODO;
+		rv = -SQSH_ERROR_INTEGER_OVERFLOW;
 		goto out;
 	}
 

diff --git a/lib/primitive/rc_hash_map.c b/lib/primitive/rc_hash_map.c
@@ -177,7 +177,7 @@ sqsh__rc_hash_map_release(struct SqshRcHashMap *hash_map, const void *element) {
 			return sqsh__rc_map_release(values, element);
 		}
 	}
-	return -SQSH_ERROR_TODO;
+	return -SQSL_ERROR_ELEMENT_NOT_FOUND;
 }
 
 int

diff --git a/lib/table/export_table.c b/lib/table/export_table.c
@@ -51,7 +51,7 @@ sqsh_export_table_resolve_inode(
 		const struct SqshExportTable *table, uint32_t inode,
 		uint64_t *inode_ref) {
 	if (inode < 1) {
-		return -SQSH_ERROR_TODO;
+		return -SQSH_ERROR_INVALID_ARGUMENT;
 	}
 	return sqsh_table_get(&table->table, inode - 1, inode_ref);
 }

diff --git a/lib/utils/error.c b/lib/utils/error.c
@@ -114,6 +114,10 @@ sqsh_error_str(int error_code) {
 		return "Compression unkown";
 	case SQSH_ERROR_CURL_INVALID_RANGE_HEADER:
 		return "Invalid range header";
+	case SQSL_ERROR_ELEMENT_NOT_FOUND:
+		return "Element not found";
+	case SQSH_ERROR_INVALID_ARGUMENT:
+		return "Invalid argument";
 	case SQSH_ERROR_TODO:
 		return "Todo";
 	}