directory_iterator: fix potential over-/underflow #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 60.22% 60.24% +0.01%
==========================================
Files 58 58
Lines 4767 4769 +2
Branches 716 718 +2
==========================================
+ Hits 2871 2873 +2
Misses 1481 1481
Partials 415 415
☔ View full report in Codecov by Sentry. |
Gottox
force-pushed
the
fix/directory-inode-calculation
branch
2 times, most recently
from
6ecb4bc
to
34216be
Compare
This change improves the inode calculation in the directory iterators. Before this change the inode was checked in check_inode_consistency() and then calculated naively in directory_iterator_inode(). After this change the inode is precalculated, checked more intensively and cached in update_inode(). director_iterator_inode() is a simple getter for the cached value. This change also includes test cases for the directory iterator that check the new behavior.
Gottox
force-pushed
the
fix/directory-inode-calculation
branch
from
34216be
to
2d79e60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the inode calculation in the directory iterators. Before this change the inode was checked in check_inode_consistency() and then calculated naively in directory_iterator_inode(). After this change the inode is precalculated, checked more intensively and cached in update_inode(). director_iterator_inode() is a simple getter for the cached value.
This change also includes test cases for the directory iterator that check the new behavior.