Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: rename walker to path resolver. #139

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Sep 17, 2023

This change renames the tree walker to path resolver. This is done to better reflect the purpose of the struct and avoid misuse.

This change renames the tree walker to path resolver. This is done to
better reflect the purpose of the struct and avoid misuse.
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 73.07% and project coverage change: -0.09% ⚠️

Comparison is base (dc22591) 60.44% compared to head (80840f3) 60.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   60.44%   60.35%   -0.09%     
==========================================
  Files          58       59       +1     
  Lines        4672     4702      +30     
  Branches      706      708       +2     
==========================================
+ Hits         2824     2838      +14     
- Misses       1443     1459      +16     
  Partials      405      405              
Files Changed Coverage Δ
lib/read/tree/walker.c 50.00% <44.44%> (-23.56%) ⬇️
lib/read/tree/path_resolver.c 73.76% <73.76%> (ø)
lib/read/easy/file.c 77.27% <100.00%> (ø)
lib/read/file/file.c 60.33% <100.00%> (ø)
tools/unpack.c 30.85% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 42 Code Smells

No Coverage information No Coverage information
16.4% 16.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Gottox Gottox merged commit 2edced9 into main Sep 17, 2023
24 of 25 checks passed
@Gottox Gottox deleted the improve/rename-walker-to-path-resolver branch September 17, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant