Fix/dotenv malformed line warning#275
Closed
spartan124 wants to merge 3 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #172
missing
=, stray quotes) without any warning, causing variables to be silently unset ratherthan failing fast.
returned by
godotenv.Load()and emit clear warnings vialog.Printf. This gives thedeveloper immediate visibility into malformed
.envfiles, preventing confusing downstreamerrors in config validation.
surface loud warnings to stdout/logger instead of silently discarding them.
- Added Edge-Case Tests (
internal/config/dotenv_test.go): Covered all specified edgecases: missing equals sign, unterminated quotes, duplicate keys (last-wins behavior), comment-
only files, empty files, and Windows line endings (CRLF).
- Boosted Coverage (
internal/config/config_helpers_test.go): Added extensive tests forconfig.goenvironment helpers, pushing the overall test coverage for theinternal/configpackage to 99.2% (well beyond the 95% requirement).
effort for local development. By capturing and logging
godotenvfailures rather than tryingto partially patch/parse the environment files manually, we avoid the risk of fallback default
overrides or security loopholes for critical tokens (like
JWT_SECRET).