Fix #535: re-add Godot .gd script file detection - #667
Closed
azizur100389 wants to merge 1 commit into
Closed
Conversation
Regression: .gd files were detected in v0.4.26 but stopped being recognized in newer versions. Users with Godot projects saw "No code files found - nothing to rebuild" even when .gd files were present. Add .gd to: - CODE_EXTENSIONS in detect.py so detect() classifies them as code - _EXTENSIONS in extract.collect_files() so directory scans find them GDScript has no tree-sitter binding on PyPI, so AST extraction silently skips .gd files (existing behavior for unmapped extensions). The files still appear in detect output and are processed by the LLM-based semantic extraction subagents as code, restoring the pre-regression behavior.
Contributor
Author
|
Closing in favor of #NEW which targets the v6 default branch instead of stale v3. (Same fix, retargeted.) |
Contributor
Author
|
Replaced by #669 (same fix, retargeted to v6). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regression fix:
.gdfiles were detected in v0.4.26 but silently dropped after upgrade, causing Godot users to see "No code files found - nothing to rebuild" even when.gdfiles were present in their project.Add
.gdto:CODE_EXTENSIONSindetect.pysodetect()classifies Godot scripts as code_EXTENSIONSinextract.collect_files()so recursive directory scans pick them upGDScript has no tree-sitter binding on PyPI, so AST extraction silently skips
.gdfiles (existing behavior for unmapped extensions). The files now appear in detect output again and are processed by the LLM-based semantic extraction subagents as code, restoring the pre-regression behavior.Closes #535
Test plan
tests/test_detect.py::test_classify_godot_gd— verifiesclassify_file()returnsFileType.CODEfor.gdpathstests/test_extract.py::test_collect_files_picks_up_godot_gd— verifiescollect_files()finds.gdfiles in a directory scantest_collect_files_from_dirsupported set to include.gd