Add Path tool support for G/R/S rotation and scaling with a single selected handle #2180
+130
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
0SlowPoke0
force-pushed
the
pen_and_path_tools_fix
branch
from
6c0881b to
812bdec
Compare
Keavon
force-pushed
the
pen_and_path_tools_fix
branch
from
812bdec to
ab55281
Compare
Keavon
changed the title
|
!build |
|
Keavon
force-pushed
the
pen_and_path_tools_fix
branch
from
ab55281 to
ba3cc5a
Compare
|
!build |
|
Keavon
reviewed
Jan 13, 2025
Comment on lines
84
to
85
| if let Some(point) = selected_points.first() { | ||
| match point { |
There was a problem hiding this comment.
You can combine this if let and match, I believe.
Keavon
reviewed
Jan 13, 2025
Comment on lines
169
to
148
| if let Some(point) = selected_points.first() { | ||
| match point { |
Keavon
reviewed
Jan 13, 2025
| match point { | ||
| ManipulatorPointId::Anchor(_) => { | ||
| if let Some([handle1, handle2]) = point.get_handle_pair(&vector_data) { | ||
| if (handle1.get_handle_length(&vector_data) == 0.0 && handle2.get_handle_length(&vector_data) == 0.0) |
There was a problem hiding this comment.
Please avoid using the style 0.0 and use the 0. style instead with decimals.
Keavon
reviewed
Jan 13, 2025
| return; | ||
| } | ||
|
|
||
| if selected_points.len() == 1 { |
There was a problem hiding this comment.
Please find opportunities to avoid so much nesting here, like early returning to flatten this out. I suppose that might mean needing to return selected.original_transforms.clear(); in a number of places to keep parity with the current last line of this block.
Keavon
reviewed
Jan 13, 2025
| return; | ||
| } | ||
|
|
||
| if selected_points.len() == 1 { |
There was a problem hiding this comment.
Too much nesting here too, please find ways to early return and combine if lets together.
0SlowPoke0
force-pushed
the
pen_and_path_tools_fix
branch
from
ba3cc5a to
cc033f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr implements some parts of #1870 and also some minor improvements
Minor improvements as discussed -