Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the document auto-save system initially restore the last-viewed tab before loading the rest #2194

Merged
merged 10 commits into from
Jan 25, 2025
Merged

Make the document auto-save system initially restore the last-viewed tab before loading the rest #2194

merged 10 commits into from
Jan 25, 2025

Conversation

mTvare6
Copy link
Contributor

@mTvare6 mTvare6 commented Jan 12, 2025 •
edited
Loading

@Keavon
Copy link
Member

Keavon commented Jan 12, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 23a5ec0
https://96358b95.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Jan 12, 2025

Only autosaved documents get serialized to the browser storage, which can get the indexes out of sync. Reproduction:

  1. Create an empty document and draw something
  2. Create an empty document and do nothing to it
  3. Staying on that second tab, reload the editor

@Keavon Keavon marked this pull request as draft January 12, 2025 22:24
@Keavon Keavon changed the title Fixes last tab being opened instead of last active tab Make document auto-saving include the active tab index instead of just restoring the last tab Jan 12, 2025
@mTvare6 mTvare6 force-pushed the reload-last-active-tab branch from 23a5ec0 to addf7e8 Compare January 13, 2025 07:29
@Keavon Keavon force-pushed the master branch 2 times, most recently from 7465fad to ab724d8 Compare January 18, 2025 00:03
@mTvare6 mTvare6 marked this pull request as ready for review January 19, 2025 05:45
@mTvare6 mTvare6 force-pushed the reload-last-active-tab branch from 0c2d2af to 51071f9 Compare January 19, 2025 19:11
@Keavon
Copy link
Member

Keavon commented Jan 24, 2025

I merge in master and resolved the conflicts for you. See Discord about needed changes so it opens the last-viewed tab, so long as that tab is destined to reopen.

@Keavon Keavon marked this pull request as draft January 24, 2025 03:45
@mTvare6 mTvare6 marked this pull request as ready for review January 24, 2025 12:49
@Keavon
Copy link
Member

Keavon commented Jan 25, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for b6efd40
https://bedf7bf4.graphite.pages.dev

@Keavon Keavon changed the title Make document auto-saving include the active tab index instead of just restoring the last tab Make the document auto-save system initially restore the last-viewed tab before loading the rest Jan 25, 2025
@Keavon Keavon enabled auto-merge (squash) January 25, 2025 06:34
@Keavon Keavon merged commit 9954e49 into GraphiteEditor:master Jan 25, 2025
4 checks passed
@mTvare6 mTvare6 deleted the reload-last-active-tab branch January 25, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keavon Keavon Keavon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mTvare6 @Keavon