Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial refactor unit test file #1055

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from
Draft

Initial refactor unit test file #1055

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19646a0
Initial refactor unit test file
Apr 14, 2020
7a78901
Added @expectedException, reusable method for test routes, initial re…
jestonisumande Apr 16, 2020
83febe7
Revert gitignore (remove composer.lock), trim un used spaces
jestonisumande Apr 16, 2020
95597ea
Refactor test_route
jestonisumande Apr 20, 2020
fbf0dc3
Initial Refactor AddonTest
jestonisumande Apr 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ dist/*
_notes
_notes/*
Thumbs.db
composer.lock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lock file is important to ensure the built copy of Gravity PDF exactly matches what we run in development. My previous comment about not including it in your PR was because it was unrelated to the work you are doing. We try keep our PRs to one specific focus. In this case, refactoring the unit tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted Jake.

*.pot

# Environment File
Expand Down
Loading