Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncated merge tags in HTML attribute when included in PDF setting Rich Text fields #1562

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Aug 18, 2024

Description

Only field merge tags were being matched during rich text sanitizing. This adjustment now matches any merge tag with opening and closing {}, provided it is the only content included in a HTML attribute.

Testing instructions

  1. Add <img src="{user:user_profile_picture}" /> to Footer HTML field
  2. Save PDF settings
  3. Verify the merge tag hasn't been truncated

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (hot-patch-6.11.2@f673065). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             hot-patch-6.11.2    #1562   +/-   ##
===================================================
  Coverage                    ?   76.05%           
===================================================
  Files                       ?      248           
  Lines                       ?    12999           
  Branches                    ?      370           
===================================================
  Hits                        ?     9887           
  Misses                      ?     3104           
  Partials                    ?        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 merged commit 83e0b02 into hot-patch-6.11.2 Aug 18, 2024
13 checks passed
@jakejackson1 jakejackson1 deleted the hot-patch-6-11.3 branch August 18, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant