ADBDEV-8376: Make Madlib build Greengage compatible

[RekGRpth]

Make Madlib build Greengage compatible

Madlib 2 already supported Greenplum 6 and Greenplum 7. Add support for
Greengage 6 and Greengage 7:

1. Fix regular expressions in src/madpack/utilities.py,
   src/ports/greenplum/cmake/FindGreenplum.cmake, and
   src/ports/postgres/modules/utilities/utilities.py_in, and add additional
   condition in src/madpack/madpack.py.

2. Madlib 2 only supports Python 3, remove specific environment variables from
   src/madpack/madpack.py, and fix files src/madpack/sort-module.py,
   src/ports/postgres/CMakeLists.txt, and src/CMakeLists.txt.

3. Fix an indent error in the src/ports/postgres/madpack/SQLCommon.m4_in file.

Ticket: ADBDEV-8376

[Stolb27]

How do you plan to remove such Green(plum) mentions further? Maybe replace it with something like Green\w+ or pass as param for build system? (e.g. -DFORK_NAME)

[RekGRpth]

replace it with something like Green\w+

Good idea and less diff!

[KnightMurloc]

Is it expected that we still specify greenplum as the platform during installation?

[RekGRpth]

Is it expected that we still specify greenplum as the platform during installation?

Yes, there is a related task for renaming.

[dkovalev1]

Are there any plans to actualize README.md and ReadMe_Build.txt for greengage?

[RekGRpth]

Are there any plans to actualize README.md and ReadMe_Build.txt for greengage?

If you want to change something there, you can create a corresponding task.

[dkovalev1]

I could build it with greengage 7 with the commands:
./configure make
For greengage this procedure also worked, but need to make sure that both python2 and python3 are installed with development packages.
Described test procedure in README.md builds a docker container with PostgreSQL 10.5. We can not claim that MADlib is Greengage compatible without having test procedure adjusted and performed. So I suggest renaming this commit to "Make Madlib build Greengage compatible". And commit description should also say that it's for build.

[RekGRpth]

renaming this commit to "Make Madlib build Greengage compatible". And commit description should also say that it's for build.

done

[dkovalev1]

I could run some tests with local greengage demo cluster on ubuntu 24.

/usr/local/madlib/Current/madpack/madpack.py -p greenplum -c localhost:7000/postgres install
/usr/local/madlib/Current/madpack/madpack.py -p greenplum -c localhost:7000/postgres install-check
/usr/local/madlib/Current/madpack/madpack.py -p greenplum -c localhost:7000/postgres dev-check
/usr/local/madlib/Current/madpack/madpack.py -p greenplum -c localhost:7000/postgres unit-test