Error message hard to read #938 #985
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngrTaofeek
requested changes
Jul 4, 2022
| @@ -15,6 +15,7 @@ class TreeTrackerActivity : ComponentActivity() { | |||
| private val languageSwitcher: LanguageSwitcher by inject() | |||
| private val viewModelFactory: TreeTrackerViewModelFactory by inject() | |||
|
|
|||
| //hello this is the first change i have made | |||
There was a problem hiding this comment.
No need to add this comment. Github automatically the lines and file you made changes to.
There was a problem hiding this comment.
Yeah this was on the first commit, i was trying learn how deal with github.
| @@ -281,7 +281,7 @@ fun CustomSnackbar( | |||
| Text( | |||
| text = data.message, | |||
| style = CustomTheme.typography.regular, | |||
| color = CustomTheme.textColors.darkText | |||
| color = CustomTheme.textColors.lightText | |||
|
I'm not sure this issue was talking about the button text. I think it was referring to the black error text showing in the red box. I think this should be decided by design before committing to a change though. @EngrTaofeek can you confirm with design on this task please? |
|
@Elforama Yes, this changing the black error text in the red box as it shown below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #938
-Change the Text color to White
-add an example for the User