Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make share component accessible #1719

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ojafero
Copy link
Contributor

@ojafero ojafero commented Sep 18, 2023

Description

  • Share button can now be accessed by keyboard
  • Added label to buttons so screen readers announce what the button is for
  • Close option (x icon) on dialog can now be accessed by keyboard

Screenshots

Before After
before_1 after_1

Checklist:

  • I have performed a self-review of my own code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant