Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parseSegmentValue bug when route contains data object #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cariboufute
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features) (sorry, tried but was overwhelmed by all the fake router properties to fake)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #152

What is the new behavior?

The URL now changes with locale change even when the path is '' and there is a data key in the route object.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@timmyrosen
Copy link

Please merge this

@kadosh1000
Copy link

Also facing this bug. @cariboufute Did you manage to find any workaround until the PR merged?
Is there an easy way to use your fork?

@cariboufute
Copy link
Author

@kadosh1000 Yes, you just have to fork my copy of localize-router : https://github.com/cariboufute/localize-router

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants