Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Header component visualization #39

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yduartep
Copy link

@yduartep yduartep commented Sep 9, 2018

The objective of this change is to have the possibility of display custom component, not just in the body of the modal, but also in the header.

  • Added a new parameter in IModalDialogOptions named headerComponent used to store the custom Header component to be displayed.
  • Added a new parameter in IModalDialogSettings named headerType that will have the default value TITLE or can be changed with the value CUSTOM. If the second value is defined, the headerComponent parameter becomes mandatory.
  • New Unit test was added to test this new modal dialog behavior.
  • A new button with the title "Dialog with custom header component" was added in the demo project to display the new case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant