-
Notifications
You must be signed in to change notification settings - Fork 54
feat[next]: Multiple output domains #2225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 54 commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
768e458
First draft
tehrengruber ac7db53
Remove debugging leftovers
tehrengruber ff6e23b
Merge branch 'main' into get_domain_builtin
tehrengruber 3731810
Get domain from tuple element
tehrengruber 4bd8a51
Merge origin/main
tehrengruber 0e4eb57
Rename get_domain to get_domain_range
tehrengruber d916337
Remove compile time args
tehrengruber 25e24e9
Fix format
tehrengruber e856a18
Fix failing tests
tehrengruber 00a11a6
Fix failing tests
tehrengruber fd509c8
Merge remote-tracking branch 'origin/main' into get_domain_builtin
tehrengruber f0bb72f
Extend prototype for multiple output domains
SF-N 8f8e228
Merge branch 'main' into multiple_output_domains
SF-N d865514
Fix some tests
SF-N 65a831b
Start working on direct fo calls with multiple output domains
SF-N 510ea69
Add tests
SF-N b910167
Fix embedded domain promotion
SF-N 1066d60
Merge branch 'main' into multiple_output_domains
SF-N 8b02398
Add more tests and extend type deduction
SF-N de0e1df
Merge branch 'main' into multiple_output_domains
SF-N 5f75aff
Merge tehrengruber:get_domain_builtin
SF-N 1135e00
Merge branch 'multiple_output_domains' of github.com:SF-N/gt4py into …
SF-N 17bf432
Extend for nested tuples
SF-N 87fa841
Cleanup tests
SF-N 54dde30
Extend to also work for out arg that is a tuple
SF-N f6e6b35
Merge branch 'main' into multiple_output_domains
SF-N c280514
Add tests with restricted domain and extend to construct domain tuple…
SF-N 3d91e4c
Merge branch 'main' into multiple_output_domains
SF-N 3123d3f
Merge main
SF-N 002b4c8
Clean up
SF-N 1e86519
Extend and refactor to fix tests
SF-N b86770c
Merge branch 'main' into multiple_output_domains
SF-N ef9a29e
Fix several tests
SF-N 5c1edae
Enable multiple output domains in direct fo calls and fix some tests
SF-N e357b89
Refactor and make slices work
SF-N 93290f8
Merge main
SF-N 3a50b60
Remove num_levels from unstructured meshes and reformat
SF-N 5b1bf86
Remove num_levels from MeshDescriptor
SF-N 0440779
Try to refactor Domain vs DomainLike
SF-N 4e72b82
Update tests and address TODO
SF-N 9658d67
Revert unintensional change and pdate tests
SF-N 21b8ca6
Minor
SF-N 98420e6
fix global tmps tuple splitting
havogt 88401fe
nested direct fop call and cleanups
havogt 008a437
Merge remote-tracking branch 'upstream/main' into multiple_output_dom…
havogt a07294d
cleanup
havogt 0cc0bf4
improve past type deduction
havogt bfbfd36
fix domain type deduction
havogt 93087d8
cleanup tree_map like operations
havogt 5c771e2
Merge remote-tracking branch 'upstream/main' into multiple_output_dom…
havogt ddf95d0
refactor past_to_itir
havogt 2b33bc5
Simplify and cleanup past_to_itir
tehrengruber 35a8966
Fix doctest
tehrengruber afc3aa4
Merge branch 'main' into multiple_output_domains
SF-N 638f9e2
Merge remote-tracking branch 'origin/main' into multiple_output_domains
tehrengruber e434146
Merge remote-tracking branch 'origin_sf_n/multiple_output_domains' in…
tehrengruber 152e584
Merge branch 'main' into multiple_output_domains
edopao 1888c2d
SDFG lowering of multiple output domains (#16)
edopao 8229f34
address review comments in SDFG lowering
edopao c65107e
Merge branch 'main' into multiple_output_domains
edopao 9d89093
edit comment
edopao 6eddd52
apply review comments
edopao 899b9a2
Merge branch 'main' into multiple_output_domains
SF-N 40dccd7
remove normalize_domain
havogt 97e0a33
rename
havogt ecdfcda
Merge branch 'main' into multiple_output_domains
SF-N File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absorb in
domain(and removeif isinstance(domain_like, Sequence)case)?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After implementing this here I think this is not a good idea anymore. We need to distinguish between places where only a single domain is allowed, e.g.
allocate, and places where a tuple of domain likes, e.g. all places where thisnormalize_domainsis used. It feels simpler to just dotree_map(domain)(nested_domain_like)in all places wherenormalize_domainsis used and then to remove this function. Then it is clear that in all other places a single domain is allowed and here multiple.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good