-
Notifications
You must be signed in to change notification settings - Fork 54
build: Dropping python 3.10 support #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FlorianDeconinck
wants to merge
6
commits into
GridTools:main
Choose a base branch
from
FlorianDeconinck:all/fdeconinck/dropping_support_for_py310
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ac7cf45
Move parsing base python version
FlorianDeconinck e220101
Further dropping of 3.10
FlorianDeconinck f375960
Catch more 310 in Dockerfile, Ruff tooling
FlorianDeconinck de5d082
Markdown format
FlorianDeconinck a65fcf9
Format DType as expected from `storage`
FlorianDeconinck 05a89e7
Move `DTypeLike` in constructor to please `mypy`
FlorianDeconinck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,4 @@ | ||
| # Supported versions. The first one is considered the default | ||
| 3.10 | ||
| 3.11 | ||
| 3.12 | ||
| 3.13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,36 +47,36 @@ Ready to start contributing? We use a [fork and pull request](https://www.atlass | |
| 2. Clone your fork locally and check out the relevant branch: | ||
|
|
||
| ```bash | ||
| $ git clone [email protected]:your_name_here/gt4py.git | ||
| $ cd gt4py | ||
| $ git checkout main | ||
| git clone [email protected]:your_name_here/gt4py.git | ||
| cd gt4py | ||
| git checkout main | ||
| ``` | ||
|
|
||
| 3. Follow instructions in the [README.md](README.md) file to set up an environment for local development. | ||
|
|
||
| 4. Create a branch for local development: | ||
|
|
||
| ```bash | ||
| $ git checkout -b name-of-your-bugfix-or-feature | ||
| git checkout -b name-of-your-bugfix-or-feature | ||
| ``` | ||
|
|
||
| Now you can make your changes locally. Make sure you follow the project code style documented in [CODING_GUIDELINES.md](CODING_GUIDELINES.md). | ||
|
|
||
| 5. When you're done making changes, check that your code complies with the project code style and other quality assurance (QA) practices using `pre-commit`. Additionally, make sure that unit and regression tests pass for all supported Python versions by running `nox`: | ||
|
|
||
| ```bash | ||
| $ pre-commit run | ||
| $ nox | ||
| pre-commit run | ||
| nox | ||
| ``` | ||
|
|
||
| Read [Testing](#testing) section below for further details. | ||
|
|
||
| 6. Commit your changes and push your branch to GitHub: | ||
|
|
||
| ```bash | ||
| $ git add . | ||
| $ git commit -m "Your detailed description of your changes." | ||
| $ git push origin name-of-your-bugfix-or-feature | ||
| git add . | ||
| git commit -m "Your detailed description of your changes." | ||
| git push origin name-of-your-bugfix-or-feature | ||
| ``` | ||
|
|
||
| 7. Submit a pull request (PR) on [GT4Py's GitHub page](https://github.com/gridtools/gt4py). | ||
|
|
@@ -145,7 +145,7 @@ We recommended you to use `nox` for running the test suite in different environm | |
| nox --list | ||
|
|
||
| # Run a specific session | ||
| nox -s "test_cartesian-3.10(internal, cpu)" | ||
| nox -s "test_cartesian-3.11(internal, cpu)" | ||
| ``` | ||
|
|
||
| Check `nox` documentation (`nox --help`) for the complete reference. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.