쿠키 설정 바인딩 및 쿠키 저장 로직 공통화 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CookiePropertiesTest: @ConfigurationProperties 바인딩 테스트를 설계하였습니다. - CookieServiceTest: 쿠키 저장 시 HttpServletResponse에 Set-Cookie 헤더가 정상적으로 추가되는지 검증 테스트를 설계하였습니다.
- application 설정 값을 기반으로 쿠키 속성을 바인딩했습니다 - accessToken, email 등을 응답에 쿠키로 저장하는 유틸을 구현했습니다
- accessToken 재발급 시 직접 헤더 설정 대신 공통 쿠키 저장 유틸을 사용했습니다. - 중복 로직을 제거하고 책임을 분리했습니다.
- 로그인 필터 및 시큐리티 설정에 쿠키 유틸 주입하였습니다. - 인증 흐름 내 쿠키 기반 응답 처리 가능하도록 구성하였습니다.
- JwtProvider를 직접 호출해 쿠키를 설정하던 로직을 제거했습니다. - CookieService를 통해 accessToken 저장 책임을 일관되게 위임했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 연관된 이슈
📝작업 내용
💬리뷰 시 요구사항 (선택)