Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Blocker Project #14

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Web Blocker Project #14

merged 3 commits into from
Oct 29, 2023

Conversation

ShashiNova
Copy link
Contributor

No description provided.

@iamwatchdogs iamwatchdogs self-requested a review October 28, 2023 18:10
@iamwatchdogs iamwatchdogs added the hacktoberfest Opted for hacktoberfest label Oct 28, 2023
iamwatchdogs
iamwatchdogs reviewed Oct 28, 2023
View reviewed changes
Copy link
Contributor

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShashiNova it's recommended to add a README.md file.

iamwatchdogs
iamwatchdogs requested changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShashiNova Please make the required changes.

blocker.py Outdated Show resolved Hide resolved
iamwatchdogs
iamwatchdogs requested changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes both for lining checks (previous code review) and maintain the file structure.

blocker.py Outdated Show resolved Hide resolved
iamwatchdogs
iamwatchdogs approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@iamwatchdogs iamwatchdogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes have been made. Review and Approved by @iamwatchdogs.

@iamwatchdogs iamwatchdogs merged commit 9393510 into Grow-with-Open-Source:main Oct 29, 2023
1 check passed
@iamwatchdogs iamwatchdogs added the hacktoberfest-accepted Successfully accepted pull request for hacktoberfest label Oct 29, 2023
@iamwatchdogs
Copy link
Contributor

Thank you for contributing @ShashiNova, make sure to check your contributions on GitHub Pages.

@iamwatchdogs iamwatchdogs changed the title blocker.py Web Blocker Project Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamwatchdogs iamwatchdogs iamwatchdogs approved these changes

Assignees

@ShashiNova ShashiNova

Labels
hacktoberfest Opted for hacktoberfest hacktoberfest-accepted Successfully accepted pull request for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShashiNova @iamwatchdogs