Skip to content

Fix/challenge #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2unmini wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −8
Open

Fix/challenge #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
083f262
[Fix] 쿼리 경고 수정
2unmini May 15, 2025
c6f81e2
[Fix] Count 쿼리 최적화
2unmini May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/main/java/dev/book/challenge/repository/ChallengeRepositoryImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@

import com.querydsl.core.types.Projections;
import com.querydsl.core.types.dsl.BooleanExpression;
import com.querydsl.jpa.impl.JPAQuery;
import com.querydsl.jpa.impl.JPAQueryFactory;
import dev.book.challenge.dto.response.ChallengeReadResponse;
import lombok.RequiredArgsConstructor;
import org.springframework.data.domain.Page;
import org.springframework.data.domain.PageImpl;
import org.springframework.data.domain.Pageable;
import org.springframework.data.support.PageableExecutionUtils;
import org.springframework.stereotype.Repository;

import java.util.List;
Expand Down Expand Up @@ -37,12 +38,11 @@ public Page<ChallengeReadResponse> search(String title, String text, Pageable pa
.limit(pageable.getPageSize())
.fetch();

long totalCount = jpaQueryFactory.select(challenge.count())
JPAQuery<Long> countQuery = jpaQueryFactory.select(challenge.count())
.from(challenge)
.where(eqTitle(title),
eqText(text))
.fetchOne();
return new PageImpl<>(content, pageable, totalCount);
eqText(text));
return PageableExecutionUtils.getPage(content, pageable, countQuery::fetchOne);

}

Expand Down
3 changes: 0 additions & 3 deletions src/main/java/dev/book/challenge/user_challenge/repository/UserChallengeRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ public interface UserChallengeRepository extends JpaRepository<UserChallenge, Lo

@Query("""
SELECT uc FROM UserChallenge uc
JOIN FETCH uc.challenge c
JOIN FETCH c.challengeCategories cc
JOIN FETCH cc.category ca
WHERE uc.user.id=:id
""")
List<UserChallenge> findChallengeByUserId(Long id, Pageable pageable);
Expand Down