This repository has been archived by the owner on May 9, 2022. It is now read-only.
Fix unresolved symbol when linking statically #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When linking a Lime program statically using the -static command line option, Lime's generated main function looks for a function named extension_webm_register_prims. Prior to this commit, this function was called openfl_webm_register_prims, causing a linker error. This commit renames this function to extension_webm_register_prims and adds an openfl_webm_register_prims wrapper function for backwards compatibility just in case someone relied on this function name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linking a Lime program statically using the
-staticcommand line option, Lime's generatedmainfunction looks for a function namedextension_webm_register_prims. Prior to this commit, this function was calledopenfl_webm_register_prims, causing a linker error.This commit renames this function to
extension_webm_register_primsand adds anopenfl_webm_register_primswrapper function for backwards compatibility just in case someone relied on the old function name.