Clean up code

Guerra24 · Oct 16, 2021 · 4fee281 · 4fee281
1 parent f0588d8
commit 4fee281
Show file tree

Hide file tree

Showing 7 changed files with 38 additions and 28 deletions.
diff --git a/LRReader.Shared/ApiConnection.cs b/LRReader.Shared/ApiConnection.cs
@@ -110,7 +110,7 @@ public static async Task<GenericApiResponse<T>> GetResultInternal<T>(this IRestR
 				}
 				catch (Exception e)
 				{
-					var properties = new Dictionary<string, string>
+					/*var properties = new Dictionary<string, string>
 					{
 						{ "Path", restResponse.ResponseUri?.PathAndQuery ?? "" },
 						{ "Code", restResponse.StatusCode.ToString() }
@@ -125,7 +125,7 @@ public static async Task<GenericApiResponse<T>> GetResultInternal<T>(this IRestR
 					{
 						ErrorAttachmentLog.AttachmentWithBinary(json, "input.json.bz2", "application/x-bzip2")
 					};
-					Crashes.TrackError(e, properties, attachments); // We are getting bad data from the instance, send stack trace
+					Crashes.TrackError(e, properties, attachments);*/ // We are getting bad data from the instance, send stack trace
 					return default;
 				}
 			});
@@ -157,7 +157,7 @@ public static async Task<GenericApiResult> GetError(this IRestResponse restRespo
 				}
 				catch (Exception e)
 				{
-					var properties = new Dictionary<string, string>
+					/*var properties = new Dictionary<string, string>
 					{
 						{ "Path", restResponse.ResponseUri?.PathAndQuery ?? "" },
 						{ "Code", restResponse.StatusCode.ToString() }
@@ -166,7 +166,7 @@ public static async Task<GenericApiResult> GetError(this IRestResponse restRespo
 					{
 						ErrorAttachmentLog.AttachmentWithText(restResponse.Content, "error-response.txt")
 					};
-					Crashes.TrackError(e, properties, attachments);
+					Crashes.TrackError(e, properties, attachments);*/
 					return null;
 				}
 			});

diff --git a/LRReader.Shared/Internal/Util.cs b/LRReader.Shared/Internal/Util.cs
@@ -3,6 +3,21 @@
 using System.Threading;
 using System.Threading.Tasks;
 
+namespace LRReader.Shared
+{
+	[AttributeUsage(AttributeTargets.All)]
+	public class IntAttribute : Attribute
+	{
+		public int Value { get; private set; }
+
+		public IntAttribute(int value)
+		{
+			this.Value = value;
+		}
+
+	}
+}
+
 namespace LRReader.Shared.Internal
 {
 	internal static class Util

diff --git a/LRReader.Shared/Providers/ArchivesProvider.cs b/LRReader.Shared/Providers/ArchivesProvider.cs
@@ -25,9 +25,9 @@ public static async Task<bool> Validate()
 			if (r.StatusCode != HttpStatusCode.OK)
 				return false;
 
-			var decoded = GetArchives();
-
-			return decoded != null;
+			//var decoded = GetArchives();
+			//return decoded != null;
+			return true;
 		}
 
 		public static async Task<List<Archive>> GetArchives()

diff --git a/LRReader.Shared/Providers/CategoriesProvider.cs b/LRReader.Shared/Providers/CategoriesProvider.cs
@@ -23,9 +23,9 @@ public static async Task<bool> Validate()
 			if (r.StatusCode != HttpStatusCode.OK)
 				return false;
 
-			var decoded = GetCategories();
-
-			return decoded != null;
+			//var decoded = GetCategories();
+			//return decoded != null;
+			return true;
 		}
 
 		public static async Task<List<Category>> GetCategories()

diff --git a/LRReader.Shared/Providers/DatabaseProvider.cs b/LRReader.Shared/Providers/DatabaseProvider.cs
@@ -24,9 +24,9 @@ public static async Task<bool> Validate()
 			if (r.StatusCode != HttpStatusCode.OK)
 				return false;
 
-			var decoded = GetTagStats();
-
-			return decoded != null;
+			//var decoded = GetTagStats();
+			//return decoded != null;
+			return true;
 		}
 
 		public static async Task<List<TagStats>> GetTagStats()

diff --git a/LRReader.Shared/Services/Settings.cs b/LRReader.Shared/Services/Settings.cs
@@ -381,6 +381,11 @@ public enum AppTheme
 	}
 	public enum TagsPopupLocation
 	{
-		Top, Middle, Bottom
+		[Int(12)]
+		Top,
+		[Int(3)]
+		Middle,
+		[Int(11)]
+		Bottom
 	}
 }
diff --git a/LRReader.UWP/Views/Items/GenericArchiveItem.cs b/LRReader.UWP/Views/Items/GenericArchiveItem.cs
@@ -1,10 +1,12 @@
-using LRReader.Shared.Models.Main;
+using LRReader.Shared;
+using LRReader.Shared.Models.Main;
 using LRReader.Shared.Services;
 using LRReader.Shared.ViewModels.Items;
 using LRReader.UWP.Extensions;
 using Microsoft.Extensions.DependencyInjection;
 using System;
 using System.Collections.Generic;
+using System.Reflection;
 using System.Threading.Tasks;
 using Windows.ApplicationModel.Resources;
 using Windows.Devices.Input;
@@ -189,19 +191,7 @@ public async void TagsGrid_PointerEntered(object sender, PointerRoutedEventArgs
 			if (_open && !TagsFlyout.IsOpen)
 			{
 				_open = false;
-				FlyoutPlacementMode placement = FlyoutPlacementMode.Auto;
-				switch (Service.Settings.TagsPopup)
-				{
-					case TagsPopupLocation.Top:
-						placement = FlyoutPlacementMode.RightEdgeAlignedBottom;
-						break;
-					case TagsPopupLocation.Middle:
-						placement = FlyoutPlacementMode.Right;
-						break;
-					case TagsPopupLocation.Bottom:
-						placement = FlyoutPlacementMode.RightEdgeAlignedTop;
-						break;
-				}
+				var placement = (FlyoutPlacementMode)typeof(TagsPopupLocation).GetMember(Service.Settings.TagsPopup.ToString())[0].GetCustomAttribute<IntAttribute>(false).Value;
 				TagsFlyout.ShowAt(TagsGrid, new FlyoutShowOptions
 				{
 					Position = e.GetCurrentPoint(TagsGrid).Position,