Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cblas::Index #148

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Remove cblas::Index #148

merged 1 commit into from
Mar 23, 2024

Conversation

Chris00
Copy link
Collaborator

@Chris00 Chris00 commented Mar 23, 2024

In the standard library, “search” functions return usize. I have done the same in cblas, which fixes the error discussed in an earlier PR.

@GuillaumeGomez
Copy link
Owner

CI failure looks pretty bad:

2024-03-23T22:25:03.4472449Z    Compiling gsl-examples v0.4.6 (/__w/rust-GSL/rust-GSL/examples)
2024-03-23T22:25:03.5968476Z     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.16s
2024-03-23T22:25:03.5976407Z      Running `target/debug/combination`
2024-03-23T22:25:03.5999577Z thread 'main' panicked at library/core/src/panicking.rs:152:5:
2024-03-23T22:25:03.6000089Z All subsets of {0,1,2,3} by size:
2024-03-23T22:25:03.6001077Z unsafe precondition(s) violated: slice::from_raw_parts requires the pointer to be aligned and non-null, and the total size of the slice not to exceed `isize::MAX`
2024-03-23T22:25:03.6002069Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@Chris00
Copy link
Collaborator Author

Chris00 commented Mar 23, 2024 via email

@GuillaumeGomez
Copy link
Owner

A fix for a later time then. Thanks for this fix!

@GuillaumeGomez GuillaumeGomez merged commit 037a06c into GuillaumeGomez:master Mar 23, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants