Skip to content

Use proper entity service schemas & replace async_forward_entry_setup with async_forward_entry_setups #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use proper entity service schemas & replace async_forward_entry_setup with async_forward_entry_setups #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions custom_components/openhasp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,26 +184,19 @@ async def async_setup(hass, config):

hass.data[DOMAIN] = {CONF_PLATE: {}}

component = hass.data[DOMAIN][CONF_COMPONENT] = EntityComponent(
_LOGGER, DOMAIN, hass
)
component = hass.data[DOMAIN][CONF_COMPONENT] = EntityComponent(_LOGGER, DOMAIN, hass)

WAKEUP_SERVICE_SCHEMA = cv.make_entity_service_schema({})
PAGE_NEXT_SERVICE_SCHEMA = cv.make_entity_service_schema({})
PAGE_PREV_SERVICE_SCHEMA = cv.make_entity_service_schema({})

Copy link
Collaborator

@dgomes dgomes Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also include the other services , just to maintain everything coherent

component.async_register_entity_service(SERVICE_WAKEUP, WAKEUP_SCHEMA, "async_wakeup")
component.async_register_entity_service(SERVICE_PAGE_NEXT, PAGE_NEXT_SCHEMA, "async_change_page_next")
component.async_register_entity_service(SERVICE_PAGE_PREV, PAGE_PREV_SCHEMA, "async_change_page_prev")
component.async_register_entity_service(SERVICE_PAGE_CHANGE, {vol.Required(ATTR_PAGE): int}, "async_change_page")
component.async_register_entity_service(SERVICE_LOAD_PAGE, {vol.Required(ATTR_PATH): cv.isfile}, "async_load_page")
component.async_register_entity_service(SERVICE_CLEAR_PAGE, {vol.Optional(ATTR_PAGE): int}, "async_clearpage")

component.async_register_entity_service(SERVICE_WAKEUP, {}, "async_wakeup")
component.async_register_entity_service(
SERVICE_PAGE_NEXT, {}, "async_change_page_next"
)
component.async_register_entity_service(
SERVICE_PAGE_PREV, {}, "async_change_page_prev"
)
component.async_register_entity_service(
SERVICE_PAGE_CHANGE, {vol.Required(ATTR_PAGE): int}, "async_change_page"
)
component.async_register_entity_service(
SERVICE_LOAD_PAGE, {vol.Required(ATTR_PATH): cv.isfile}, "async_load_page"
)
component.async_register_entity_service(
SERVICE_CLEAR_PAGE, {vol.Optional(ATTR_PAGE): int}, "async_clearpage"
)
component.async_register_entity_service(
SERVICE_COMMAND,
{
Expand Down