Fix system id for caloCellPosition [temporary, should refactor this] #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Brieuc, |
|
Hi Jana, good point, I will change that and create an issue! |
|
Updated, see issue #430 |
|
Hi Brieuc, |
|
LGTM. Could you also add those changes to https://github.com/HEP-FCC/k4RecCalorimeter? |
|
I recently updated the tests, will merge now and check the test results of the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the system id in order to have meaningful positions for the ECAL barrel. This is a temporary fix, we should probably refactor this to avoid such a hard coding, possibly with another way to retrieve the system ID on the flight if it is possible. Or by having only one position tool here and by calling this algorithm once per sub-system in the config file.