Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Create POST Testimonial API #1043

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[Backend] Create POST Testimonial API #1043

merged 1 commit into from
Jun 12, 2024

Conversation

shivamgaur99
Copy link
Contributor

@shivamgaur99 shivamgaur99 commented Jun 12, 2024 •
edited
Loading

Issue that this pull request solves

Closes: #1039

POST Testimonial API to add testimonials.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

image

@auto-assign auto-assign bot requested a review from Kajol-Kumari June 12, 2024 08:50
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 12, 2024
View reviewed changes
backend/app/routes/testimonial/index.js
const getTestimonials = require('./getTestimonials');

router.post('/', validationMiddleware(postTestimonialValidationSchema), authMiddleware, postTestimonial);

Check failure

Code scanning / CodeQL

Missing rate limiting High test

This route handler performs
authorization
Loading
, but is not rate-limited.
@shivamgaur99
Copy link
Contributor Author

shivamgaur99 commented Jun 12, 2024 •
edited
Loading

@Kajol-Kumari please review in your free time

Kajol-Kumari
Kajol-Kumari approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Kajol-Kumari Kajol-Kumari added level2 Bug fixing, adding small features. gssoc GSSoC'24 Label labels Jun 12, 2024
@Kajol-Kumari Kajol-Kumari merged commit e09bbe7 into HITK-TECH-Community:main Jun 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kajol-Kumari Kajol-Kumari Kajol-Kumari approved these changes

Assignees

@shivamgaur99 shivamgaur99

Labels
gssoc GSSoC'24 Label level2 Bug fixing, adding small features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Backend] Create POST Testimonial API
2 participants
@shivamgaur99 @Kajol-Kumari