-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Update Broadcast Modal Description Population and Refactor form for Styling Consistency #1061
Fix Update Broadcast Modal Description Population and Refactor form for Styling Consistency #1061
Conversation
@Kajol-Kumari could you please review the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivamgaur99 i can see a lot of un-necessary changes in this pr, please remove all the redundant changes and keep the folder structure same i.e Carousel/Edit
… Consistency" This reverts commit bb06edc.
@Kajol-Kumari Changes done please review, i thought edit folder should be in admin folder thats why earlier i put it into manage broadcast folder |
@Kajol-Kumari could you please check ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The earlier change included the classes for dark and light mode which has been completely removed in this pr
- After successful update the toast message is saying
successfully approved
which is wrong, it should have beensuccessfully updated
instead.
@Kajol-Kumari both changes done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shivamgaur99 the dark and light mode seems to be messed up in this pr, check the https://deploy-preview-1061--hitk-tech-community.netlify.app/ and compare it with https://hitk-tech-community.netlify.app/
Hi @Kajol-Kumari its working fine can you check it again and please send ss if you are seeing any different |
i check more than 10 times by switching dark mode and light mode its showing same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes doesn't seem to impact other pages ui but not sure why deploy preview is misbehaving, approving the pr for now
thank you so much |
reverted the pr as merging this actually messed up the dark and light mode theme |
@Kajol-Kumari Can you tell me why its happening, while i have'nt change others file, may be after some times it will okay |
multiple reason can add to it
|
Closes: #1045
Refactor update broadcast functionality to handle approval status and ensure style consistency
Types of changes
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that applyScreenshots