Fix Update Broadcast Modal Description Population and Refactor form for Styling Consistency#1061
Conversation
|
@Kajol-Kumari could you please review the changes? |
Kajol-Kumari
left a comment
There was a problem hiding this comment.
@shivamgaur99 i can see a lot of un-necessary changes in this pr, please remove all the redundant changes and keep the folder structure same i.e Carousel/Edit
β¦ Consistency" This reverts commit bb06edc.
|
@Kajol-Kumari Changes done please review, i thought edit folder should be in admin folder thats why earlier i put it into manage broadcast folder |
|
@Kajol-Kumari could you please check ? |
Kajol-Kumari
left a comment
There was a problem hiding this comment.
- The earlier change included the classes for dark and light mode which has been completely removed in this pr
- After successful update the toast message is saying
successfully approvedwhich is wrong, it should have beensuccessfully updatedinstead.
@Kajol-Kumari both changes done |
Kajol-Kumari
left a comment
There was a problem hiding this comment.
@shivamgaur99 the dark and light mode seems to be messed up in this pr, check the https://deploy-preview-1061--hitk-tech-community.netlify.app/ and compare it with https://hitk-tech-community.netlify.app/
|
Hi @Kajol-Kumari its working fine can you check it again and please send ss if you are seeing any different |
|
i check more than 10 times by switching dark mode and light mode its showing same |
Kajol-Kumari
left a comment
There was a problem hiding this comment.
changes doesn't seem to impact other pages ui but not sure why deploy preview is misbehaving, approving the pr for now
thank you so much |
|
reverted the pr as merging this actually messed up the dark and light mode theme |
|
@Kajol-Kumari Can you tell me why its happening, while i have'nt change others file, may be after some times it will okay |
|
multiple reason can add to it
|







Closes: #1045
Refactor update broadcast functionality to handle approval status and ensure style consistency
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots