Skip to content

Bug: Reset password fixed #1083

Closed
BHS-Harish wants to merge 1 commit intoHITK-TECH-Community:mainfrom
BHS-Harish:fix-issue-989
Closed

Bug: Reset password fixed #1083
BHS-Harish wants to merge 1 commit intoHITK-TECH-Community:mainfrom
BHS-Harish:fix-issue-989

Conversation

@BHS-Harish
Copy link
Copy Markdown
Contributor

@BHS-Harish BHS-Harish commented Jul 28, 2024

Issue that this pull request solves

Closes: #989

Proposed changes

Reset password functionality added as per given requirement

Screenshots

bandicam.2024-07-28.19-35-11-525.mp4

@auto-assign auto-assign Bot requested a review from Kajol-Kumari July 28, 2024 14:38
github-advanced-security[bot]
github-advanced-security AI found potential problems Jul 28, 2024
View reviewed changes
Comment thread backend/app/routes/Q&A/answers/updateAnswerStatus.js
const { status } = req.body;

// query fro updating
const [err, result] = await to(answers.findOneAndUpdate({ _id: id }, { $set: { isApproved: status } }));

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query object depends on a [user-provided value](1).
Comment thread backend/app/routes/Q&A/question/updateQuestionStatus.js
const { status } = req.body;

// query fro updating
const [err, result] = await to(question.findOneAndUpdate({ _id: id }, { $set: { isApproved: status } }));

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query object depends on a [user-provided value](1).
Comment thread backend/app/routes/admin/deleteAdmin.js
const { id } = req.body;

const [err, admin] = await to(Admin.findByIdAndDelete(id));
const [err, admin] = await to(Admin.findByIdAndDelete(id));

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query object depends on a [user-provided value](1).
Comment thread backend/app/routes/broadcast/updateBroadcast.js
};

delete data.id;

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query object depends on a [user-provided value](1).
Comment thread backend/app/routes/broadcast/updateBroadcast.js
};

delete data.id;

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources

This query object depends on a [user-provided value](1).
Comment thread backend/app/routes/joinUs/index.js
router.post('/', validation(JoinUsValidationSchema), postJoinUs);
router.get('/', authMiddleware, getJoinUs);
router.delete('/deleteJoinUs',deleteJoinUs)
router.delete('/deleteJoinUs', deleteJoinUs);

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [a database access](1), but is not rate-limited.
Comment thread backend/app/routes/teamMember/index.js
router.post('/addTeamMember', authMiddleware, upload.single('image'), addTeam);
router.put('/updateTeamMember',authMiddleware,upload.single('image'),updateTeamMember);
router.delete("/deleteTeamMember",authMiddleware,deleteTeamMember);
router.put('/updateTeamMember', authMiddleware, upload.single('image'), updateTeamMember);

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread backend/app/routes/teamMember/index.js
router.post('/addTeamMember', authMiddleware, upload.single('image'), addTeam);
router.put('/updateTeamMember',authMiddleware,upload.single('image'),updateTeamMember);
router.delete("/deleteTeamMember",authMiddleware,deleteTeamMember);
router.put('/updateTeamMember', authMiddleware, upload.single('image'), updateTeamMember);

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [a database access](1), but is not rate-limited. This route handler performs [a database access](2), but is not rate-limited.
Comment thread backend/app/routes/teamMember/index.js
router.put('/updateTeamMember',authMiddleware,upload.single('image'),updateTeamMember);
router.delete("/deleteTeamMember",authMiddleware,deleteTeamMember);
router.put('/updateTeamMember', authMiddleware, upload.single('image'), updateTeamMember);
router.delete('/deleteTeamMember', authMiddleware, deleteTeamMember);

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [authorization](1), but is not rate-limited.
Comment thread backend/app/routes/teamMember/index.js
router.put('/updateTeamMember',authMiddleware,upload.single('image'),updateTeamMember);
router.delete("/deleteTeamMember",authMiddleware,deleteTeamMember);
router.put('/updateTeamMember', authMiddleware, upload.single('image'), updateTeamMember);
router.delete('/deleteTeamMember', authMiddleware, deleteTeamMember);

Check failure

Code scanning / CodeQL

Missing rate limiting

This route handler performs [a database access](1), but is not rate-limited. This route handler performs [a file system access](2), but is not rate-limited.
@BHS-Harish
Copy link
Copy Markdown
Contributor Author

BHS-Harish commented Jul 28, 2024

Hey @Kajol-Kumari

Please review the request :)

Kajol-Kumari
Kajol-Kumari requested changes Jul 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BHS-Harish

  1. 52 file changes, this pr has a lot of unnecessary changes, can u please clean it?
  2. The build is failing please fix it.

@BHS-Harish
Copy link
Copy Markdown
Contributor Author

BHS-Harish commented Jul 28, 2024

@BHS-Harish

  1. 52 file changes, this pr has a lot of unnecessary changes, can u please clean it?
  2. The build is failing please fix it.

When i changed particular file within a folder that shows as the entire folder were changed that is the reason why 52 files were changed

@Kajol-Kumari
Copy link
Copy Markdown
Member

Kajol-Kumari commented Jul 28, 2024

@BHS-Harish

  1. 52 file changes, this pr has a lot of unnecessary changes, can u please clean it?
  2. The build is failing please fix it.

When i changed particular file within a folder that shows as the entire folder were changed that is the reason why 52 files were changed

You can add particular files only under using git add <file_path1> <file_path2> ... instead of doing git add . this will avoid any unnecessary file change to come under the pr

@BHS-Harish
Copy link
Copy Markdown
Contributor Author

BHS-Harish commented Jul 28, 2024

Okay let me close the current pr and raise new one

@BHS-Harish BHS-Harish closed this Jul 28, 2024
@BHS-Harish BHS-Harish deleted the fix-issue-989 branch July 28, 2024 17:58
@BHS-Harish BHS-Harish restored the fix-issue-989 branch July 28, 2024 18:22
@BHS-Harish BHS-Harish deleted the fix-issue-989 branch July 28, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kajol-Kumari Kajol-Kumari Kajol-Kumari requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

To Solve the bug in forgot password feature

3 participants

@BHS-Harish @Kajol-Kumari @github-advanced-security