Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show contactus data on admin dashboard #829

Merged

Conversation

adityanandanx
Copy link
Contributor

Issue that this pull request solves

Closes: #740

Proposed changes

Display the contactus data as fetched from /getContactUs endpoint.

Brief description of what is fixed or changed

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface
image

Other information

**Note: ** delete functionality has not been implemented on the backend as of creating this PR and thus this doesn't include the same.

Copy link

welcome bot commented Jan 10, 2024

Thank you and congrats🎉 for opening this pull request!💖

Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@thevirengarg
Copy link
Collaborator

thevirengarg commented Jan 11, 2024

@iMADi-ARCH Please explain changes you made in detail.

@adityanandanx
Copy link
Contributor Author

@thevirengarg The logic and ui is the same as of the joinus page.
I fetch the data from the endpoint /getContactUs and display it as cards.
The styling of the card is same as in joinus so as to maintain consistency.

@adityanandanx
Copy link
Contributor Author

Also the Reply button has a mailto link so as to facilitate replying to the messages.

@Aditi-Dahiya
Copy link
Collaborator

@thevirengarg The logic and ui is the same as of the joinus page. I fetch the data from the endpoint /getContactUs and display it as cards. The styling of the card is same as in joinus so as to maintain consistency.

@iMADi-ARCH , Can you please keep the colors used consistent and not include multiple colors? Specifically, Red color seems to go off. Rest is great.

@adityanandanx
Copy link
Contributor Author

@Aditi-Dahiya
image

Are these good? sorry I am not very good at choosing colors 😓

@Aditi-Dahiya
Copy link
Collaborator

@Aditi-Dahiya
image

Are these good? sorry I am not very good at choosing colors 😓

Okay so for now you can replace the red color with the pink tone used throughout the website.

@adityanandanx
Copy link
Contributor Author

@Aditi-Dahiya
image

@Aditi-Dahiya
Copy link
Collaborator

@Aditi-Dahiya
image

Yeah, good for now 👍🏻

@thevirengarg thevirengarg added level1 Wiki or Major Documentation work. gssoc GSSoC'24 Label labels Jan 11, 2024
Copy link
Collaborator

@thevirengarg thevirengarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iMADi-ARCH First, You need to get the issue assigned to you and then make a PR.

@thevirengarg thevirengarg self-requested a review January 11, 2024 18:43
Copy link
Collaborator

@thevirengarg thevirengarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to the issue and comment on it so I can assign it you and then I will review this PR.

@thevirengarg thevirengarg self-requested a review January 11, 2024 18:50
@adityanandanx
Copy link
Contributor Author

@iMADi-ARCH First, You need to get the issue assigned to you and then make a PR.

#740 has no more assignment tag
image

@thevirengarg
Copy link
Collaborator

@iMADi-ARCH First, You need to get the issue assigned to you and then make a PR.

#740 has no more assignment tag image

Just ignore it, comment on it then i will assign it to you

@adityanandanx
Copy link
Contributor Author

@iMADi-ARCH First, You need to get the issue assigned to you and then make a PR.

#740 has no more assignment tag image

Just ignore it, comment on it then i will assign it to you

i did just now.

@Shreyas-SAS
Copy link

Please assign him the issue and process the review as per repository workflow of accepting PRs.

Copy link
Collaborator

@thevirengarg thevirengarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

improve the styling of the cards which should resonate with the website's theme and also add some comments in your code. It is advisable to add screenshots of before and after in your PR description while making improvements to the UI .

@thevirengarg thevirengarg self-requested a review January 11, 2024 19:10
Copy link
Collaborator

@Aditi-Dahiya Aditi-Dahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling issues to be addressed before merging.

@adityanandanx
Copy link
Contributor Author

improve the styling of the cards which should resonate with the website's theme and also add some comments in your code. It is advisable to add screenshots of before and after in your PR description while making improvements to the UI .

Every page in dashboard has almost the same card styling which is what i have followed. Also there should have been a common card component and the button component is also being exported as Button1, Button2, Button3 etc which does not makes much sense. Maybe an issue should be opened to refactor some of the styling.

image
image
image

I will add comments to the code.

Copy link
Collaborator

@thevirengarg thevirengarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iMADi-ARCH Everything is fine, just add some comments.

@thevirengarg thevirengarg self-requested a review January 16, 2024 04:23
@thevirengarg thevirengarg merged commit 72b4052 into HITK-TECH-Community:main Jan 16, 2024
7 checks passed
Copy link

welcome bot commented Jan 16, 2024

Congrats on merging your first pull request! 🙌 🎉 ⚡️ Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step.😄🙌
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level1 Wiki or Major Documentation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Integrate GET Contact Us Data
4 participants