[Frontend] Integrate Get Team on Admin Panel Fixed #868
Conversation
|
Thank you and congrats🎉 for opening this pull request!💖 Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀 |
| {d.description} | ||
| <h3 style={{fontWeight:"bolder"}}>About</h3> {d.description} | ||
| </div> | ||
| <div className={style["content"]}> |
There was a problem hiding this comment.
the linkedIn, github and twitter urls should be url and should open in a new tab once someone clicks on it.
| {d.icon} | ||
| <h4> {d.name} </h4> | ||
| <div style={{display:"flex", justifyContent:"center",alignItems:"center"}}> | ||
| <img src={d.image} style={{margin:"auto", borderRadius:"50%", width:"200px", height:"200px"}} alt="" /> |
There was a problem hiding this comment.
If the image doesn't load due to some reason, can we show a default image?
There was a problem hiding this comment.
Image is not loading because In database there is no valid image url
There was a problem hiding this comment.
ok I will make this changes
There was a problem hiding this comment.
In database, the image is getting stored in /upload/teamMember folder so don't expect an url to come, instead you should use relative path to render the same.
Kajol-Kumari
added
gssoc
|
@Kajol-Kumari I had updated it can you please check. I am putting this image here because database image urls are wrong. so image is not displaying. I had added default image also.
|
|
@Kajol-Kumari Updated can you please check. |
|
Congrats on merging your first pull request! 🙌 🎉 ⚡️ Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step.😄🙌 |
Issue that this pull request solves
Under Admin Panel, About Us => Manage Team It should call the Get Team api and the actual data should be populated
Issue
Issue Link resolve #789
Closes: #789
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyImportant information
There a important thing I am telling. Db does not had valid profiles so dp is not displaying. and Api get all team members get data without authenticating. I had added the token in fetching so no problem in merging this pr. But You need to Improve backend api.