[Bug] Fix backend addteammembers api is Fixed#876
[Bug] Fix backend addteammembers api is Fixed#876Kajol-Kumari merged 12 commits intoHITK-TECH-Community:mainfrom
Conversation
|
@Kajol-Kumari can you please check this and merge it. then i will start working on #725 |
Kajol-Kumari
left a comment
There was a problem hiding this comment.
@hemu21 what exactly have you fixed in this pr? There is an issue with multer upload and al i see in this pr is just comments and payload change
|
@Kajol-Kumari don't merge this pr if you merge it again you will get error. |
|
@Kajol-Kumari Now you can merge it. Now there will be no errors. |
|
@Kajol-Kumari can you please merge it. I will start my next issue. |
Kajol-Kumari
left a comment
There was a problem hiding this comment.
@hemu21 please remove those commented lines and it should be good to merge
| /* eslint-disable prefer-const */ | ||
| /* eslint-disable consistent-return */ | ||
| /* eslint-disable no-unused-vars */ | ||
| /* eslint-disable prettier/prettier */ |
There was a problem hiding this comment.
can you please remove these un-necessary changes?
There was a problem hiding this comment.
@Kajol-Kumari If i remove those 4 line while commiting the changes it askes to change the entire file.
| @@ -1,3 +1,11 @@ | |||
| /* eslint-disable import/newline-after-import */ | |||
There was a problem hiding this comment.
[neat]please remove these un-necessary changes.
| @@ -1,3 +1,11 @@ | |||
| /* eslint-disable import/newline-after-import */ | |||
There was a problem hiding this comment.
[neat]please remove these un-necessary changes.
There was a problem hiding this comment.
@Kajol-Kumari @Kajol-Kumari If i remove those 4 line while commiting the changes it askes to change the entire file. Changing the entire file may effect other function so i added that comments. They are unnecessary. but to commit changes they are necessary other wise we have to change all those files. I hope you understand.
There was a problem hiding this comment.
the problem is these lines are disabling all the linting checks and so i can't allow it to be merged. can you please raise a new pr with just those 2 required change?
Issue that this pull request solves
There is problem with addTeamMembers api. Because it frontend is unable to add team members and throwing errors. fixing it is most important to fix frontend problems. By merging this pr. Backend is add team member endpoint is ready for Frontend development.
Issue
Issue Link resolve #872
Closes: #872
Brief description of what is fixed or changed
I fixed the addteammembers endpoint file in backend. It has a function that function is wrong I corrected it.
How to test it
Check for the below thing in db. why because I added it.
{ description:"This is for checking the api", full_name: "testing", teams: ["Aman","anubhav"], __v: 0, _id: "664251826c3bb95cd441ebd9" }try to add team members form this api.
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply