Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the select domain button for light theme #880

Merged

Conversation

Stiffpixels
Copy link
Contributor

Issue that this pull request solves

Closes: #879

Proposed changes

Brief description of what is fixed or changed

  • fixed the look of select domain input control in light mode.
  • fixed the transparent background of the select panel in light mode.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Video of the fix

2024-05-15.08-46-58.mp4

Copy link

welcome bot commented May 15, 2024

Thank you and congrats🎉 for opening this pull request!💖

Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@Stiffpixels
Copy link
Contributor Author

@Kajol-Kumari requesting a review from you.

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and Clean !
LGTM 👍

@Kajol-Kumari Kajol-Kumari added level1 Wiki or Major Documentation work. gssoc GSSoC'24 Label labels May 15, 2024
@Kajol-Kumari Kajol-Kumari merged commit e813bee into HITK-TECH-Community:main May 15, 2024
6 checks passed
Copy link

welcome bot commented May 15, 2024

Congrats on merging your first pull request! 🙌 🎉 ⚡️ Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step.😄🙌
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@Kajol-Kumari
Copy link
Member

Hi @Stiffpixels We have similar issue under the addTeam form of admin panel, can you fix there as well? Feel free to open a new issue for the same.
Screenshot 2024-05-15 at 8 32 02 PM

@Stiffpixels
Copy link
Contributor Author

Hi @Stiffpixels We have similar issue under the addTeam form of admin panel, can you fix there as well? Feel free to open a new issue for the same.
Screenshot 2024-05-15 at 8 32 02 PM

For sure will get back to you with the issue tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level1 Wiki or Major Documentation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Join us form select input not visible properly
2 participants