Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resource Sharing Form] fixed alignment of the input fields in the form #940

Merged
merged 4 commits into from
May 23, 2024

Conversation

shivamgaur99
Copy link
Contributor

@shivamgaur99 shivamgaur99 commented May 20, 2024

Issue that this pull request solves

Closes: #935

fixed alignment of input text field of resource sharing form below are screenshots

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

image
image

Copy link

welcome bot commented May 20, 2024

Thank you and congrats🎉 for opening this pull request!💖

Please make sure you have followed our Contributing Guidelines.🙌 We will test out your code and reply in a bit with some pointers and requests.💿 There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 If you haven't filled the template out, Please do so!🚀
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 20, 2024 18:23
@shivamgaur99 shivamgaur99 changed the title fixes alignment of resource sharing form [Resource Sharing Form] fixed alignment of the input fields in the form May 21, 2024
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-22 at 9 47 47 PM

it still breaking for ipad mini and ipad air screens, please fix the same

@shivamgaur99
Copy link
Contributor Author

@Kajol-Kumari issue fixed, checked in all devices now its not breaking

image
image

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert .env change it will be good to be merged.

backend/.env Outdated
@@ -1,9 +1,9 @@
MONGO_DB_URL=<mongoDB_URL>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cane we please revert this file change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check and sorry for late

@Kajol-Kumari Kajol-Kumari added level1 Wiki or Major Documentation work. gssoc GSSoC'24 Label labels May 23, 2024
@Kajol-Kumari Kajol-Kumari merged commit fa0368e into HITK-TECH-Community:main May 23, 2024
4 checks passed
Copy link

welcome bot commented May 23, 2024

Congrats on merging your first pull request! 🙌 🎉 ⚡️ Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step.😄🙌
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@shivamgaur99 shivamgaur99 deleted the fix/issue-935 branch May 24, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level1 Wiki or Major Documentation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Resource Sharing Form] alignment of the input fields in the form is incorrect.
2 participants