-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add GitHub Actions core test matrix #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,84 @@ | ||||||
| name: Core Tests | ||||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| branches: | ||||||
| - main | ||||||
| pull_request: | ||||||
|
|
||||||
| concurrency: | ||||||
| group: core-tests-${{ github.workflow }}-${{ github.ref }} | ||||||
| cancel-in-progress: true | ||||||
|
|
||||||
| jobs: | ||||||
| core-tests: | ||||||
| name: ${{ matrix.name }} core tests | ||||||
| runs-on: ubuntu-latest | ||||||
|
||||||
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-22.04 |
Outdated
Copilot
AI
Mar 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python -m pip install ${{ matrix.extra_pip }} is unquoted, so if extra_pip ever contains multiple packages or version specifiers with spaces, word-splitting can produce surprising results. Quoting and/or using a YAML list for extra dependencies would make this more robust.
| python -m pip install ${{ matrix.extra_pip }} | |
| python -m pip install "${{ matrix.extra_pip }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider explicitly setting workflow
permissions(for example,contents: read) since this job only checks out the repo and runs tests. Relying on the repository default GITHUB_TOKEN permissions is avoidable and can unintentionally grant broader write access than needed.