style: fix bare except Exception clauses#75
Closed
mango766 wants to merge 1 commit intoHKUDS:mainfrom
Closed
Conversation
…ommit updates bare `except Exception:` clauses to `except Exception as e:`. Bare excepts without variable assignment can hide bugs and make debugging difficult. Binding the exception to a variable is a standard Python best practice.
Collaborator
|
This PR changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #74. \n\nThis PR updates bare
except Exception:clauses toexcept Exception as e:. Bare excepts without variable assignment can hide bugs and make debugging difficult. Binding the exception to a variable is a standard Python best practice. Even if the exception isn't used immediately, it's safer and clearer for the future.