-
Notifications
You must be signed in to change notification settings - Fork 18
Split infrastructure types into zngur.h #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Split infrastructure types into zngur.h #67
Conversation
|
@HKalbasi looks like rust-lang/rust#115746 is hitting us again, that panic behavior is now in stable. How would you like me to handle this? |
|
Thanks for the PR! I'm generally on board with #48 and this implementation looks good for the start. Is it feasible to also keep the single file version working and make it configurable? I think the single file version is more suitable for small projects and people who want to try zngur. It also addresses the backward compatibility issue. Backward compatibility is not a dead end, but it is good to avoid breakage if possible, specially for this kind of breakage which affect every project.
Ah, that was decided to keep the thread id. But we can do the workaround proposed there (normalizing the output and removing the thread id) and keep the ability of auto-fixing the tests. |
|
I implemented the normalizing so CI should become green if you rebase on the main branch. |
|
@HKalbasi I think it should be possible to support the old behavior, too. My preference is to have the new split mode the default. Would you object to smaller projects needing to invoke |
|
I don't have a strong opinion on the default. We can even go far and have no default, force user to provide either |
Working towards #48, this PR splits zngur infrastructure types (
rust::Unit,rust::Ref,rust::RefMut, and others) into a newzngur.hthat is#included bygenerated.h.This obviously comes with some infrastructure changes. Now, clients must be concerned with include paths - notice the changes to the example
Makefiles to now add-I.to their C++ compiler invocations. We also now have a-o path/to/output/dirargument to zngur.I think this is a reasonable milestone to get some feedback on the overall design. Please let me know what you think! If we do merge this, I think it should be a breaking change. We could make the default argument to
-obe the CWD to approximate backwards compatibility, but I think that runs the risk of confusing users.